> On April 3, 2018, 7:13 p.m., Gilbert Song wrote: > > LGTM, before landing this patch, could we verify the nested cgroup is > > alwasy supportted after kernel 2.6.23?
Nested freezer cgroup is supported since kernel **2.6.28** ``` freezer (since Linux 2.6.28; CONFIG_CGROUP_FREEZER) The freezer cgroup can suspend and restore (resume) all pro? cesses in a cgroup. Freezing a cgroup /A also causes its children, for example, processes in /A/B, to be frozen. ``` Note, that we are trying to create a directory using `/sys/fs/cgroup/freezer/mesos/test` path. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200392 ----------------------------------------------------------- On April 3, 2018, 4:19 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66404/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 4:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > ------- > > Previously, we were checking for nested cgroup support while trying to > create a linux launcher. This was necessary to make sure that the > kernel supports creating nested cgroups. As we don't support old > kernel versions which don't support nested cgroups, this check can be > safely removed. > > > Diffs > ----- > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/66404/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >