----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66443/#review200496 -----------------------------------------------------------
Ship it! Ship It! - John Kordich On April 4, 2018, 5:58 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66443/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 5:58 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > ------- > > This needed to use the Stout API so that the correct Windows > implementation is used, as `::chdir` is part of the CRT. > > Also included used but not included `stout/os/*` headers. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > 898326360d6b4f0a50d6ef3f7c86141d0aa70438 > > > Diff: https://reviews.apache.org/r/66443/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >