----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review200603 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/stat.hpp Lines 66 (patched) <https://reviews.apache.org/r/66435/#comment281370> Did you mean `const int_fd& fd`? 3rdparty/stout/include/stout/os/posix/stat.hpp Lines 99-101 (patched) <https://reviews.apache.org/r/66435/#comment281371> Ditto on `const int_fd& fd` 3rdparty/stout/include/stout/os/posix/stat.hpp Lines 133 (patched) <https://reviews.apache.org/r/66435/#comment281372> Ditto on `const int_fd& fd` - Akash Gupta On April 4, 2018, 5:52 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66435/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 5:52 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > ------- > > These should be refactored to share the common code, and the > additional overloads added to the other APIs too. However, it is not > currently necessary, and would go unused. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/stat.hpp > 58353742b39bac4fbfcb2ab7708f0f8719ea5b3b > 3rdparty/stout/include/stout/os/windows/stat.hpp > c04953ee42f45dd80b6362fbeeddf4a0a20e7412 > > > Diff: https://reviews.apache.org/r/66435/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
