----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/#review200604 -----------------------------------------------------------
Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:54 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66436/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 5:54 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > ------- > > The functions `os::stat::size()` and `os::stat::isdir()` are now > overloaded for an `int_fd` type, using `fstat()` on POSIX, and the > equivalent functions with a `HANDLE` on Windows. This allowed us to > remove the use of `::fstat()`, which was not abstracted, and not > supported on Windows without the use of a CRT integer file descriptor. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp 63dd2c1f629ac316d0b31f8a854e482ae6eda634 > 3rdparty/libprocess/src/http_proxy.cpp > 25d63791e4788a488f96303aabeed0fa77ad7992 > > > Diff: https://reviews.apache.org/r/66436/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
