----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/ -----------------------------------------------------------
(Updated April 9, 2018, 10:20 a.m.) Review request for mesos, Andrew Schwartzmeyer and James Peach. Repository: mesos Description ------- This avoids unix's assumption that `pid_t` is a signed integer (which is not the case on Windows) and explicitly shows whether a pid has been assigned from launching. We also changed argument name in `reaped` method to `_pid` to avoid shadowing. Diffs (updated) ----- src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 Diff: https://reviews.apache.org/r/66481/diff/3/ Changes: https://reviews.apache.org/r/66481/diff/2-3/ Testing ------- `make` on Linux. Thanks, Zhitao Li