> On April 5, 2018, 8:26 p.m., Benjamin Mahler wrote: > > looks like all of these ASSERTs can be EXPECTs?
Existing tests are all using ASSERTs. We can perform a sweeping change separately if desired. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66343/#review200623 ----------------------------------------------------------- On March 28, 2018, 11:23 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66343/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 11:23 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Jason Lai. > > > Bugs: MESOS-8746 > https://issues.apache.org/jira/browse/MESOS-8746 > > > Repository: mesos > > > Description > ------- > > Added test for difference operator of hashset. > > > Diffs > ----- > > 3rdparty/stout/tests/hashset_tests.cpp > d2b7bf248647c63c00c8c82b8176130c87c50eb4 > > > Diff: https://reviews.apache.org/r/66343/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
