----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200921 -----------------------------------------------------------
src/master/http.cpp Line 1115 (original), 1111-1113 (patched) <https://reviews.apache.org/r/66464/#comment281821> For the master operator API, we keep the `master->someMethod()` calls inside the call-specific handlers. See `Master::Http::listFiles()`, for example. It's a small change, but I would suggest moving the `master->reconcileOperations()` call into `Master::Http::reconcileOperations()` for consistency. - Greg Mann On April 9, 2018, 9:30 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66464/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 9:30 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Implemented operation status reconciliation. > > > Diffs > ----- > > src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > > > Diff: https://reviews.apache.org/r/66464/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests` on GNU/Linux > > https://reviews.apache.org/r/66468/ adds new tests. > > > Thanks, > > Gaston Kleiman > >
