----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200931 -----------------------------------------------------------
I'm getting a test failure on `ROOT_XFS_QuotaTest.RecoverOldContainers` with these patches enabled. When we restart the agent with the XFS isolator enabled, we skip the running task because there isn't a project ID on the sandbox. Then the containerizer tells us to watch that container ID but we return a failure because we don't know anything about it. That failure causes the containerizer to kill the task. So we need to update `XfsDiskIsolatorProcess::recover` to store a placeholder to handle this case. - James Peach On April 4, 2018, 5:41 p.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66173/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 5:41 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-6575 > https://issues.apache.org/jira/browse/MESOS-6575 > > > Repository: mesos > > > Description > ------- > > MESOS-6575 > > > Diffs > ----- > > src/tests/containerizer/xfs_quota_tests.cpp > 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe > > > Diff: https://reviews.apache.org/r/66173/diff/3/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >