----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66408/#review201015 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On April 4, 2018, 3:59 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66408/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 3:59 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8717 > https://issues.apache.org/jira/browse/MESOS-8717 > > > Repository: mesos > > > Description > ------- > > This patch adds new helper classes for CSI plugin and node capabilities, > removed helpers for the removed csi.Version proto message, and makes > the VolumeState proto message uses csi::v0::VolumeCapability. > > NOTE: This is not future-proof if there is a breaking change in > VolumeCapability, we might need to change VolumeState to support > multiple CSI versions in the future. > > > Diffs > ----- > > src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a > src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 > src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff > src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a > > > Diff: https://reviews.apache.org/r/66408/diff/2/ > > > Testing > ------- > > This patch cannot be compiled standalone. Tests done later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
