> On March 27, 2018, 12:14 p.m., Greg Mann wrote:
> > src/common/resources_utils.cpp
> > Lines 696-698 (patched)
> > <https://reviews.apache.org/r/66050/diff/6/?file=1988969#file1988969line696>
> >
> > No period at the end of error messages. Here and below.
Are you sure? That is not consistent with the error messages that this method
will return for the other operations.
For example:
```
if (!operation->has_launch()) {
return Error(
"A LAUNCH offer operation must have"
" the Offer.Operation.launch field set.");
}
```
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review200055
-----------------------------------------------------------
On April 9, 2018, 9:18 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> -----------------------------------------------------------
>
> (Updated April 9, 2018, 9:18 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new offer operations are implemented as speculative operations, but
> we will use validation to make them non-speculative on API level so that
> we can transition later without a breaking change.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
> src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518
> src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
> src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf
> src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
> src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e
> src/tests/persistent_volume_tests.cpp
> 4edf781711d9efdb994114aeb6289b6af750b87a
> src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d
>
>
> Diff: https://reviews.apache.org/r/66050/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
