> On April 14, 2018, 12:25 a.m., Gaston Kleiman wrote: > > Thanks for the cleanup! > > > > I think we could get rid of quite some boilerplate with a helper that > > creates a `ContainerInfo::DockerInfo`.
Good point! - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201146 ----------------------------------------------------------- On April 13, 2018, 11:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66615/ > ----------------------------------------------------------- > > (Updated April 13, 2018, 11:57 p.m.) > > > Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and > Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The Docker containerizer tests were manually creating the `TaskInfo` > for the tasks they wanted to launch. We can remove some of that > boilerplate by adopting the `createTask` helper. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 847258daadf3c37d9071151616b18fc79d850ce8 > src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e > > > Diff: https://reviews.apache.org/r/66615/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 27). > > > Thanks, > > James Peach > >