----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/ -----------------------------------------------------------
(Updated April 17, 2018, 4:35 p.m.) Review request for mesos, Alexander Rukletsov and Michael Park. Changes ------- Avoided moving when given an lvalue as suggested by alexr. Repository: mesos Description (updated) ------- While it was already possible to create a `hashmap` over move-only values, we still performed a copy in `put`, making it hard to dynamically add elements with the expected stout semantics. This patch relaxes the requirements on the value argument to `put` so that instead of copyable we now only require move-constructible types. Diffs (updated) ----- 3rdparty/stout/include/stout/hashmap.hpp 91085b8d8ad5d35c39c8cc95e3d4765d82d9a8db Diff: https://reviews.apache.org/r/66608/diff/2/ Changes: https://reviews.apache.org/r/66608/diff/1-2/ Testing ------- `make check` Thanks, Benjamin Bannier