----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review201356 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/master/master.proto Lines 179-186 (patched) <https://reviews.apache.org/r/66052/#comment282541> `s/resource_provider_id/provider_id/g`. Or, we probably don't need to mention anything about `provider_id`, just say that `slave_id` must be set if `volume` is an agent-local resource, and must be unset if `volume` is an external resource. Also, a volume from a resource provider could also be a persistent volume, so the first sentence is not accurate. include/mesos/master/master.proto Lines 197-204 (patched) <https://reviews.apache.org/r/66052/#comment282542> Ditto. include/mesos/v1/master/master.proto Lines 177-184 (patched) <https://reviews.apache.org/r/66052/#comment282545> Ditto. include/mesos/v1/master/master.proto Lines 195-202 (patched) <https://reviews.apache.org/r/66052/#comment282546> Ditto. - Chun-Hung Hsiao On April 17, 2018, 6:36 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66052/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 6:36 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-8747 > https://issues.apache.org/jira/browse/MESOS-8747 > > > Repository: mesos > > > Description > ------- > > The same API could be used in the future to grow or shrink CSI volumes, > but currently only persistent volumes are supported. > > > Diffs > ----- > > include/mesos/master/master.proto aa63904a33290a3beda162bbc9f44b56ab04a1e7 > include/mesos/v1/master/master.proto > ddb28f96b2a3a439bb9a829995a9a3015f65ba43 > > > Diff: https://reviews.apache.org/r/66052/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
