----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201438 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 839 (patched) <https://reviews.apache.org/r/66308/#comment282676> One line apart. Actually, let's move this back to it's original place so all `/api/v1/*` endpoints are declared together. src/slave/slave.cpp Lines 8189 (patched) <https://reviews.apache.org/r/66308/#comment282678> Maybe add a comment saying that checking `additionalResources` is enough because all resources needs to be published must have been checked before? - Chun-Hung Hsiao On April 18, 2018, 2:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66308/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 2:28 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8735 > https://issues.apache.org/jira/browse/MESOS-8735 > > > Repository: mesos > > > Description > ------- > > By delaying the construction of the agent's resource provider manager > we prepare for a following patch introducing a dependency on the > resource provider manager on the agent's ID. > > Depending on whether the agent was able to recover an agent ID from > its log or still needs to obtain on in a first registration with the > master, we can only construct the resource provider manager after > different points in the initialization of the agent. To capture the > common code we introduce a helper function performing the necessary > steps. > > > Diffs > ----- > > src/slave/slave.hpp d00c7b2e2466fd1de71e9e55343a27d3808bde3e > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66308/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
