> On April 18, 2018, 6:57 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 1001 (patched) > > <https://reviews.apache.org/r/61096/diff/7/?file=2003265#file2003265line1001> > > > > I see `gpr` in here which looks like a typo for `grp`?
No. It's GPR, a library used in grpc core: https://github.com/grpc/grpc/blob/master/src/core/lib/gpr/README.md - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201443 ----------------------------------------------------------- On April 17, 2018, 3:16 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61096/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 3:16 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-7881 > https://issues.apache.org/jira/browse/MESOS-7881 > > > Repository: mesos > > > Description > ------- > > This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC > 3rdparty library in CMake. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 > 3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2 > cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d > src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc > > > Diff: https://reviews.apache.org/r/61096/diff/7/ > > > Testing > ------- > > `sudo make check` with CMake > > NOTE: Testing on Windowns is not done yet. > > > Thanks, > > Chun-Hung Hsiao > >
