----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66707/#review201516 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 1271 (patched) <https://reviews.apache.org/r/66707/#comment282800> Better to name it as `ROOT_RunTaskWithCommandInfoWithInvalidUser` to be consistent with the existing test `ROOT_RunTaskWithCommandInfoWithoutUser`. src/tests/slave_tests.cpp Lines 1293-1294 (patched) <https://reviews.apache.org/r/66707/#comment282801> A newline between. - Qian Zhang On April 19, 2018, 6:12 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66707/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 6:12 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8585 > https://issues.apache.org/jira/browse/MESOS-8585 > > > Repository: mesos > > > Description > ------- > > Added a test that launches a task as an unknown user and verifies > that an appropriate status update is generated by the agent. > > > Diffs > ----- > > src/tests/slave_tests.cpp 04f7acad47aa980d507bbe29b29db5eb050c02f3 > > > Diff: https://reviews.apache.org/r/66707/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >