----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201517 -----------------------------------------------------------
src/slave/slave.cpp Lines 2543 (patched) <https://reviews.apache.org/r/66708/#comment282802> Nit: Switch the order of these two parameters since we use `message` before `reason` in the code below. And can we change `[=]` to `[&]`? - Qian Zhang On April 19, 2018, 6:13 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66708/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 6:13 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8585 > https://issues.apache.org/jira/browse/MESOS-8585 > > > Repository: mesos > > > Description > ------- > > Refactored how the agent sends a TASK_DROPPED status update to > remove code duplication. This also makes the agent consistently > send the executor ID in all these status updates. > > > Diffs > ----- > > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > > > Diff: https://reviews.apache.org/r/66708/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
