----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review201631 -----------------------------------------------------------
LGTM, but I wonder whether it would make sense to keep the assertions and reject outdated resources more generally based on e.g., resource versions. - Benjamin Bannier On April 12, 2018, 5:37 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65976/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 5:37 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8492 > https://issues.apache.org/jira/browse/MESOS-8492 > > > Repository: mesos > > > Description > ------- > > Allowed profiles to be missing from `DiskProfileAdaptor`. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > a07620d1c4bf618f669575b3e183bf598da905a6 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 300ea12687de487737ce91066ab4e74d9b3430e6 > > > Diff: https://reviews.apache.org/r/65976/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
