> On April 20, 2018, 7:53 a.m., Benjamin Bannier wrote: > > src/Makefile.am > > Lines 1529-1536 (original), 1521-1525 (patched) > > <https://reviews.apache.org/r/66577/diff/2/?file=2002979#file2002979line1532> > > > > We can merge these two blocks now.
I was following the convention to split apart implementation files and header files ;) But will do. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/#review201612 ----------------------------------------------------------- On April 17, 2018, 3:03 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66577/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 3:03 a.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu. > > > Bugs: MESOS-8724 > https://issues.apache.org/jira/browse/MESOS-8724 > > > Repository: mesos > > > Description > ------- > > CSI proto compilation is disabled due to MESOS-8749, which is resolved > by bumping CSI to v0.2. This patch enables the compilation again. > > > Diffs > ----- > > src/CMakeLists.txt 31af9eaf302122b844e7599944097ad1c3faae3a > src/Makefile.am 07eb13851967b8a28b46afa3304a9d4e298a5016 > src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8 > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > > > Diff: https://reviews.apache.org/r/66577/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
