----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review202123 -----------------------------------------------------------
Patch looks great! Reviews applied: [66683] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 18, 2018, 3:14 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 3:14 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > ------- > > Updated address field of new CLI config to accept URLs. > > > Diffs > ----- > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/3/ > > > Testing > ------- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://<address_of_a_remote_mesos_master>.com:5061" > ``` > On the server providing `http://<address_of_a_remote_mesos_master>.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
