-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66773/
-----------------------------------------------------------
(Updated April 30, 2018, 1:52 p.m.)
Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.
Changes
-------
Fixed math in comment.
Bugs: MESOS-8275
https://issues.apache.org/jira/browse/MESOS-8275
Repository: mesos
Description
-------
The functions `mode()`, `dev()`, and `inode()` are unused and do not
make sense on Windows, so they were explicitly deleted. The function
`mtime()` is used and has a logical mapping, `GetFileTime()`. However,
Windows reports time differently from POSIX, so a conversion must also
be performed such that the API `os::stat::mtime()` remains consistent
with its POSIX version.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/permissions.hpp
453e60c7268db516c2c94501e11a92fe8f490498
3rdparty/stout/include/stout/os/windows/stat.hpp
c04953ee42f45dd80b6362fbeeddf4a0a20e7412
3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d
Diff: https://reviews.apache.org/r/66773/diff/3/
Changes: https://reviews.apache.org/r/66773/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
