----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/ -----------------------------------------------------------
(Updated May 1, 2018, 9:42 a.m.) Review request for mesos, Jason Lai and James Peach. Changes ------- Review comments. Bugs: MESOS-8725 https://issues.apache.org/jira/browse/MESOS-8725 Repository: mesos Description ------- If `TaskInfo.max_completion_time` is set, docker executor will kill the task immediately. We reuse the `shutdown` method to achieve a forced kill ignoring any `KillPolicy`. Framework should only received a `TASK_FAILED` state with `REASON_MAX_COMPLETION_TIME_REACHED` reason. Diffs (updated) ----- src/docker/executor.cpp 1d672112bae889cc9d19343a59e0ff66569785c4 Diff: https://reviews.apache.org/r/66283/diff/5/ Changes: https://reviews.apache.org/r/66283/diff/4-5/ Testing ------- Thanks, Zhitao Li