> On April 30, 2018, 5:20 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 459 (patched) > > <https://reviews.apache.org/r/66220/diff/8/?file=2014377#file2014377line459> > > > > Suggestion for the TODO: Make `MOUNT` a meaningful parameter value for > > this test, or create a new fixture to avoid testing against it. > > > > BTW, would it be hard to do what you did for `MOUNT` in the > > `ShrinkVolume` test?
Yes it is harder here because there is not conceivable way for a framework to receive both a `MOUNT` volume and free disk resource on the same `MOUNT`, so framework cannot even construct such operation from offered resources. > On April 30, 2018, 5:20 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 837 (patched) > > <https://reviews.apache.org/r/66220/diff/8/?file=2014377#file2014377line837> > > > > To make this test more succinct, how about doing > > `{CREATE(volume), GROW_VOLUME(volume, addition), LAUNCH(task)}` so we > > don't need the subsequent `acceptOffers`? I like this suggestion. will try it out. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202157 ----------------------------------------------------------- On April 27, 2018, 1:04 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 1:04 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/8/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
