----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202251 -----------------------------------------------------------
src/tests/master_validation_tests.cpp Lines 1497 (patched) <https://reviews.apache.org/r/66858/#comment284002> We usually use backticks for field names in comments. Ditto below. src/tests/master_validation_tests.cpp Lines 1528 (patched) <https://reviews.apache.org/r/66858/#comment284003> s/`has incompatible disk`/`are incompatible`/ src/tests/master_validation_tests.cpp Lines 1535 (patched) <https://reviews.apache.org/r/66858/#comment284004> Suggestion: Make the volume on a PATH disk so it cannot be grown with a ROOT disk. src/tests/master_validation_tests.cpp Lines 1552 (patched) <https://reviews.apache.org/r/66858/#comment284005> s/`for`/`if`/ src/tests/master_validation_tests.cpp Lines 1566 (patched) <https://reviews.apache.org/r/66858/#comment284006> Suggestion: remove "for 'GrowVolume'" for consistency. Also: if the agent has no RESIZE_VOLUME capability. src/tests/master_validation_tests.cpp Lines 1655 (patched) <https://reviews.apache.org/r/66858/#comment284009> s/`for`/`if`/ src/tests/master_validation_tests.cpp Lines 1657 (patched) <https://reviews.apache.org/r/66858/#comment284010> Hmm... we don't have this check when validating `GrowVolume` because we are counting on the fact that adding anything disk to a MOUNT disk will result in two resources. But I guess for the validation test maybe it's a good idea to also test this for `GrowVolume`. What do you think? src/tests/master_validation_tests.cpp Lines 1677 (patched) <https://reviews.apache.org/r/66858/#comment284007> s/`for`/`if`/ src/tests/master_validation_tests.cpp Lines 1692 (patched) <https://reviews.apache.org/r/66858/#comment284008> Suggestion: remove "for 'ShrinkVolume'" for consistency. Also: if the agent has no RESIZE_VOLUME capability. - Chun-Hung Hsiao On April 27, 2018, 10:07 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66858/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 10:07 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > Added tests for validation of `GrowVolume` and `ShrinkVolume`. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > a5229610a81dfac9d358597135b63ee51de86659 > > > Diff: https://reviews.apache.org/r/66858/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
