----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/#review202274 -----------------------------------------------------------
Ship it! LGTM, but could you please create a ticket for fixing the weird semantics of `os::system`? - Benjamin Bannier On April 24, 2018, 4:40 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66776/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 4:40 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > The previous check for `None()` was missing the case where the > program exited with a non-zero exit status. > > > Diffs > ----- > > 3rdparty/libprocess/src/memory_profiler.cpp > 5d6e9dc9b6d26c0efd5f2383d5ad36a136861591 > > > Diff: https://reviews.apache.org/r/66776/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
