-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66993/
-----------------------------------------------------------

(Updated May 8, 2018, 1:36 p.m.)


Review request for mesos, Andrei Budnik and James Peach.


Bugs: MESOS-8884
    https://issues.apache.org/jira/browse/MESOS-8884


Repository: mesos


Description
-------

This test was flaky because termination could already happened when we
set up the expectation. Given that we already verified task state, I do
not see checking container termination explicitly is necessary, so
removing the expectation should fix the flakiness.


Diffs (updated)
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 
d834e531a550028cd57ac409c9312dd22138e8d5 


Diff: https://reviews.apache.org/r/66993/diff/2/

Changes: https://reviews.apache.org/r/66993/diff/1-2/


Testing
-------

GTEST_FILTER="DockerContainerizerTest.ROOT_DOCKER_MaxCompletionTime" 
./bin/mesos-tests.sh --gtest_repeat=100 --verbose


Thanks,

Zhitao Li

Reply via email to