> On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote: > > support/build-virtualenv > > Lines 49-51 (original), 49-51 (patched) > > <https://reviews.apache.org/r/67059/diff/1/?file=2019381#file2019381line49> > > > > I didn't know where else to comment to open this issue: > > > > We should add a BIG AND LOUD deprecation warning to the existing > > scripts that devs must start using the Python 3 scripts, as on "June 1st" > > the existing Python 3 scripts WILL BE DELETED. > > > > Something to that effect :)
/r/67099/ > On mai 10, 2018, 8:34 après-midi, Andrew Schwartzmeyer wrote: > > support/python3/apply-reviews.py > > Lines 2-17 (patched) > > <https://reviews.apache.org/r/67059/diff/1/?file=2019385#file2019385line2> > > > > It's unfortunate that due to a staged replacement, we can't review the > > diffs of these on ReviewBoard :/ > > > > Armand, for the purposes of review, could you put up a parallel review > > where the scripts are replaced so that we can review the diff, and then > > when it's given ship-its, we take the finished ported scripts and put them > > here (trusting they're the same as the reviewed ones). /r/67101/ - Armand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review202864 ----------------------------------------------------------- On mai 11, 2018, 9:57 après-midi, Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67059/ > ----------------------------------------------------------- > > (Updated mai 11, 2018, 9:57 après-midi) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, > and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > The scripts are in a temporary directory, support/python3. > > The scripts have been ported using 2to3, the official tool to do so. > Many of these scripts require testing from the community before being > used by default. > > The script building the virtual environment and the git hooks have > been updated to use the new scripts if the environment variable > `MESOSSUPPORTPYTHON` is set to `3` by the user. > > > Diffs > ----- > > support/README.md e812e9638ca555c56e4c52e52485240e75cb8229 > support/build-virtualenv 850af89326721f34de20eb45a7e78fa391d031be > support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a > support/hooks/pre-commit 6faba98ab6db68aef1a54091a08b8db1eaac8701 > support/python3/apply-reviews.py PRE-CREATION > support/python3/generate-endpoint-help.py PRE-CREATION > support/python3/jsonurl.py PRE-CREATION > support/python3/mesos-gtest-runner.py PRE-CREATION > support/python3/mesos-split.py PRE-CREATION > support/python3/mesos-style.py PRE-CREATION > support/python3/post-reviews.py PRE-CREATION > support/python3/push-commits.py PRE-CREATION > support/python3/test-upgrade.py PRE-CREATION > support/python3/verify-reviews.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/67059/diff/2/ > > > Testing > ------- > > All the files are OK for our linter, I have tested `mesos-style.py` and > `post-reviews.py` (used for this review request). > > We will likely see error messages `TypeError: cannot use a string pattern on > a bytes-like object`, they are very easy to fix (we just need to add > `.decode("utf-8")` but detecting all of them requires to use the scripts. > Please do so and create issues. > > > Thanks, > > Armand Grillet > >
