----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202976 -----------------------------------------------------------
src/linux/fs.cpp Lines 968-1034 (original), 973-1041 (patched) <https://reviews.apache.org/r/67094/#comment285038> We can also consider changing `fs::chroot::enter` with the [`pivotRoot` implementation in runc's `rootfs_linux.go`](https://github.com/opencontainers/runc/blob/0cbfd8392fff2462701507296081e835b3b0b99a/libcontainer/rootfs_linux.go#L645-L702) - Jason Lai On May 11, 2018, 6:31 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67094/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 6:31 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li. > > > Bugs: MESOS-8792 > https://issues.apache.org/jira/browse/MESOS-8792 > > > Repository: mesos > > > Description > ------- > > Since we will need to perform additional work to configure > the chroot before entering it, split the Linux chroot API > into `fs::chroot::prepare()` and `fs::chroot::enter()`. > > > Diffs > ----- > > src/linux/fs.hpp 76dc09c38996eefd8487ba6ef4977ef2f7c9df4c > src/linux/fs.cpp fbd03b19abb9b56dbf3fb8a84d09a39171bbc1b0 > src/slave/containerizer/mesos/launch.cpp > f25d90651ef32495c9161c3eaed8a327d1b2b926 > > > Diff: https://reviews.apache.org/r/67094/diff/1/ > > > Testing > ------- > > manual > > > Thanks, > > James Peach > >
