> On May 15, 2018, 2:58 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 2381 (patched) > > <https://reviews.apache.org/r/66823/diff/5/?file=2019857#file2019857line2381> > > > > I'm curious what the performance impact of this will be during a period > > of high event throughput. Do you think it's worth adding the new helper for > > message -> event conversion now?
Sure we could do that. So the complication in devolve could be waived. but there are a lot of helpers to be added (like what we have in evolve.cpp to handle all messages). that is the reason why I leave a TODO here. > On May 15, 2018, 2:58 p.m., Greg Mann wrote: > > src/master/metrics.cpp > > Lines 612 (patched) > > <https://reviews.apache.org/r/66823/diff/5/?file=2019859#file2019859line612> > > > > Do we need this temporary variable? Here and below. yes, unordered_map[]++ would cause compilation problems. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review203166 ----------------------------------------------------------- On May 11, 2018, 1:44 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66823/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 1:44 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, > and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added per framework metrics for framework events. > > > Diffs > ----- > > src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718 > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66823/diff/5/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
