----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203444 -----------------------------------------------------------
Ship it! Haven't take a good at these but they might be candidates to use the new macros: ``` $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' src -r src/tests/containerizer/cgroups_isolator_tests.cpp: ASSERT_FALSE(check.isError()); src/tests/containerizer/cgroups_tests.cpp: ASSERT_FALSE(hierarchy.isError()); src/tests/containerizer/cgroups_tests.cpp: EXPECT_FALSE(cpuHierarchy.isError()); src/tests/containerizer/cgroups_tests.cpp: EXPECT_FALSE(memHierarchy.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(eth0.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(lo.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(gateway.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp: ASSERT_FALSE(status.isError()); src/tests/mesos.cpp: ASSERT_FALSE(hierarchy.isError()); src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); src/tests/resources_tests.cpp: EXPECT_TRUE(r.mem().isNone()); src/tests/resources_tests.cpp: EXPECT_TRUE(r.ports().isNone()); src/tests/state_tests.cpp: EXPECT_TRUE(future2->isNone()); src/tests/zookeeper_tests.cpp: ASSERT_TRUE(leader->isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_TRUE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); ``` We could fix them in a follow-up patch. - Chun-Hung Hsiao On May 18, 2018, 10:35 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 10:35 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > ----- > > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > > > Diff: https://reviews.apache.org/r/67212/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
