----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/#review203511 -----------------------------------------------------------
3rdparty/CMakeLists.txt Lines 758-759 (patched) <https://reviews.apache.org/r/67064/#comment285802> bzip doesn't seem to have a subtitle for itself (the one here is `zlib`s). So you could just call it a `high-quality data compressor`. Also the link should not have an `https`: http://www.bzip.org/ 3rdparty/CMakeLists.txt Lines 797 (patched) <https://reviews.apache.org/r/67064/#comment285808> Ditto about the subtitle. 3rdparty/CMakeLists.txt Lines 921 (patched) <https://reviews.apache.org/r/67064/#comment285809> This option is unconditionally added a little below. So in the non-Windows case, you'd end up with an option list of: `-DENABLE_TEST=OFF ... -DENABLE_TEST=ON` 3rdparty/Makefile.am Lines 280-286 (patched) <https://reviews.apache.org/r/67064/#comment285812> There seems to be mixed tabs/spaces here (and unfortunately, originally throughout this file D: ). You can set your tab settings to 8-spaces wide to see if the trailing backslaces line up. Also, why are `CPPFLAGS` and `LDFLAGS` emptied? And should we be passing `$(CONFIGURE_ARGS)` to the configure script here? 3rdparty/bzip2-1.0.6.patch Lines 7-20 (patched) <https://reviews.apache.org/r/67064/#comment285813> This seems very inconsistent style-wise... Also, can you add a note saying that `bzip2.c` and `bzip2recover.c` are not built because we are only interested in building the library (not executables). 3rdparty/bzip2-1.0.6.patch Lines 12-14 (patched) <https://reviews.apache.org/r/67064/#comment285815> You can probably move the module definitions file `libbz2.def` into the list of sources. src/Makefile.am Lines 221-226 (patched) <https://reviews.apache.org/r/67064/#comment285817> This looks like a mistake. Looks like you had temporarily commented parts of this out? - Joseph Wu On May 15, 2018, 10:09 a.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67064/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 10:09 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, > Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8064 > https://issues.apache.org/jira/browse/MESOS-8064 > > > Repository: mesos > > > Description > ------- > > These libraries being available will allow stout to be changed such that > stout can invoke libarchive instead of shelling out to tar to extract > archives. On Windows, tar usually doesn't exist, and even if it does, it > rarely supports most compression formats. On Windows, we will build > libarchive to support each of those compression formats. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 > 3rdparty/Makefile.am 8d9fa85dd65a94d91670d54dab36deea80d14996 > 3rdparty/bzip2-1.0.6.patch PRE-CREATION > 3rdparty/cmake/Versions.cmake 2828acd2aa00c8778c6c462bc594716b2b6289ba > 3rdparty/libarchive-3.3.2.patch PRE-CREATION > 3rdparty/versions.am ada998d62d012a45b2cf17256c1ae16b92d611f2 > 3rdparty/xz-5.2.3.patch PRE-CREATION > configure.ac 6e91ecf4659ebec2e124ca4b2218c830608abeb0 > src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 > > > Diff: https://reviews.apache.org/r/67064/diff/4/ > > > Testing > ------- > > I've built on Windows with CMake and have run all tests, which all pass. > I've also built on Linux with both the autotools build and cmake build and > have run all tests, which all pass. > > > Thanks, > > John Kordich > >
