> On May 23, 2018, 6:39 p.m., Benjamin Bannier wrote: > > Could you follow this up with a patch which compiles the example at least > > as part of `check`? > > > > For cmake we could e.g., add a `CMakeLists.txt` to the `example/` directory > > with just > > > > add_executable(example EXCLUDE_FROM_ALL example.cpp) > > target_link_libraries(example process) > > add_dependencies(libprocess-tests example) > > > > and add the subdirectory to `libprocess/CMakeLists.txt`. > > > > Similar for autotools. > > > > Maybe we also should format the file according to our style guide in > > another patch.
Sorry, I don't really have the time right now to work on that. But I'll volunteer to review the patch if you want to write it. > On May 23, 2018, 6:39 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/examples/example.cpp > > Line 68 (original), 68 (patched) > > <https://reviews.apache.org/r/67270/diff/1/?file=2027737#file2027737line68> > > > > Could we fix the indention here? Can you give an example of how "fixed" looks like? This way is consistent with the comments in the main function. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203676 ----------------------------------------------------------- On May 23, 2018, 5:22 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67270/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 5:22 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The 'example.cpp' file in libprocess was missing the mandatory > help string argument. > > > Diffs > ----- > > 3rdparty/libprocess/examples/example.cpp > a97665ee6b75c5b31397b5a10002fa23a7fe370a > > > Diff: https://reviews.apache.org/r/67270/diff/1/ > > > Testing > ------- > > Compiled the `example.cpp` file. > > > Thanks, > > Benno Evers > >
