----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/#review203784 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On May 24, 2018, 7:34 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67282/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 7:34 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8770 > https://issues.apache.org/jira/browse/MESOS-8770 > > > Repository: mesos > > > Description > ------- > > This change ensures that pylint will not try to lint the new Python 3 > support scripts if it is not run with Python 3. Having such a situation > results in unexpected errors such as "Unnecessary parens after 'print' > keyword". This change will not be applied in the Python 3 mesos-style. > > > Diffs > ----- > > support/mesos-style.py b7ee699e3898d795bfac97e88ad8e111392c0e3e > > > Diff: https://reviews.apache.org/r/67282/diff/1/ > > > Testing > ------- > > Applied the entire chain, run some `git commit --amend` with and without > `export MESOSSUPPORTPYTHON=3` (rebuilding the virtualenv was also done > following this change) to see if the correct Python files were linted. > > > Thanks, > > Armand Grillet > >
