----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204382 -----------------------------------------------------------
Patch looks great! Reviews applied: [67264, 67423, 67421] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 6, 2018, 12:08 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67421/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 12:08 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu. > > > Bugs: MESOS-8830 > https://issues.apache.org/jira/browse/MESOS-8830 > > > Repository: mesos > > > Description > ------- > > The current `ROOT_BusyMountPoint` test would fail because we added > support for unmounting dangling mount points in directory to gc. This > patch rewrote this test to reflect that after unmounting, the gc > succeeded, directory was gone and metrics were correctly reported. > > > Diffs > ----- > > src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 > > > Diff: https://reviews.apache.org/r/67421/diff/3/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
