> On April 18, 2018, 2:48 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > > Lines 133 (patched) > > <https://reviews.apache.org/r/66561/diff/2/?file=2004048#file2004048line133> > > > > In which case can `host.empty()` be `true`?
E.G., hdfs:///var/lib/mesos/store/docker/ > On April 18, 2018, 2:48 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > > Lines 232-235 (patched) > > <https://reviews.apache.org/r/66561/diff/2/?file=2004048#file2004048line232> > > > > Should we change `Option<string>()` and `Option<int>()` to `None()`? > > > > Or we could change it to something like: > > ``` > > URI uri = hdfsUri.get(); > > uri.set_path(paths::getImageArchiveTarPath(hdfsUri->path(), image)); > > ``` it wouldn't compile with None(). let's use the second option you provided. > On April 18, 2018, 2:48 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > > Lines 39-40 (original), 39-41 (patched) > > <https://reviews.apache.org/r/66561/diff/2/?file=2004049#file2004049line39> > > > > > > [Image::Docker::name](https://github.com/apache/mesos/blob/1.5.0/include/mesos/v1/mesos.proto#L2696:L2700) > > can already represent docker registry, did you mean changing it in future? I meant an optional URI, rephased it. > On April 18, 2018, 2:48 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Lines 148 (patched) > > <https://reviews.apache.org/r/66561/diff/2/?file=2004050#file2004050line148> > > > > Just curious, I see this flag was introduced in Mesos long time ago, > > but I do not see this flag set in any Mesos code before, so this is the > > first time that we use it in Mesos? yea, it was not consumed previously. the mesos fetcher rely on env var. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/#review201378 ----------------------------------------------------------- On June 6, 2018, 1:43 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66561/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 1:43 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-8794 > https://issues.apache.org/jira/browse/MESOS-8794 > > > Repository: mesos > > > Description > ------- > > Supported hdfs fetching in local puller. > > > Diffs > ----- > > docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a > src/hdfs/hdfs.hpp 716d13ff905e937f991f0a997e4d3cdca3b6e521 > src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174 > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 4d2e4973a0d6c99dd3447a158003b4b09e2ba477 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 509be63635e21e48a62deaf7c545575d2d8221b3 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > d7d8987d493a37d20f32ddd254dc0c3b15159951 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > f6b8f394ee83d15b74bb0a100d768b9b32235734 > src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e > > > Diff: https://reviews.apache.org/r/66561/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
