----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67476/#review204431 -----------------------------------------------------------
Patch looks great! Reviews applied: [67476] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 6, 2018, 1:56 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67476/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 1:56 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > While rare, contributions which modify any `Makefile.am` (usually > because they add or remove files) tend to break the `distcheck` target > as well as the cmake build system. > > This patch adds a section so contributors are aware that they need to > check that all build system and all make targets work when modifying > `Makefile.am` files. > > > Diffs > ----- > > docs/advanced-contribution.md f95149120d39b9517ace3ec0ac37d82d3d3a77c4 > > > Diff: https://reviews.apache.org/r/67476/diff/1/ > > > Testing > ------- > > Not a code related change. > > > Thanks, > > Alexander Rojas > >
