----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/#review204547 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/subprocess.hpp Lines 383 (patched) <https://reviews.apache.org/r/67287/#comment287103> `= {}` to match the rest of the parameters 3rdparty/libprocess/include/process/subprocess.hpp Lines 420 (patched) <https://reviews.apache.org/r/67287/#comment287104> Ditto 3rdparty/libprocess/src/subprocess_windows.hpp Lines 55 (patched) <https://reviews.apache.org/r/67287/#comment287105> Ditto - Andrew Schwartzmeyer On May 24, 2018, 3:47 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67287/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 3:47 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie > Yu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8926 > https://issues.apache.org/jira/browse/MESOS-8926 > > > Repository: mesos > > > Description > ------- > > White list fds that child processes can inherit in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 6a1262340c333b617402637e648c12769827ffc4 > 3rdparty/libprocess/src/subprocess.cpp > d7a725363251f9c54072cd7551f5598696938308 > 3rdparty/libprocess/src/subprocess_windows.hpp > c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f > > > Diff: https://reviews.apache.org/r/67287/diff/2/ > > > Testing > ------- > > All Mesos-tests > > > Thanks, > > Radhika Jandhyala > >
