> On June 12, 2018, 6:17 p.m., Jie Yu wrote: > > src/slave/gc.cpp > > Lines 262 (patched) > > <https://reviews.apache.org/r/67423/diff/2/?file=2035399#file2035399line262> > > > > This is a bit hacky. A better way should be modify `os::rmdir` to > > return `Try<Nothing, int>`. The second template parameter is the error code. > > > > Can you add a TODO?
In fact, it should return `Try<Nothing, ErrnoError>` - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/#review204623 ----------------------------------------------------------- On June 2, 2018, 5:30 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67423/ > ----------------------------------------------------------- > > (Updated June 2, 2018, 5:30 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Previously, agent gc would increment the "failed" counter if the path > does not exist, but this should not be an issue. This patch skipped such > paths in both "failed" and "succeeded" counters. > > > Diffs > ----- > > src/slave/gc.cpp 390b35e6d17d6614a73c9548decbf10739560106 > > > Diff: https://reviews.apache.org/r/67423/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
