----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204733 -----------------------------------------------------------
Patch looks great! Reviews applied: [67546, 67547] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 13, 2018, 11:02 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67547/ > ----------------------------------------------------------- > > (Updated June 13, 2018, 11:02 a.m.) > > > Review request for mesos, Alexander Rukletsov and Jan Schlicht. > > > Bugs: MESOS-8985 > https://issues.apache.org/jira/browse/MESOS-8985 > > > Repository: mesos > > > Description > ------- > > A client can request any endpoint to stream its response using > the RecordIO format. However, we never checked whether the selected > endpoint actually supports streaming, leading to an agent crash > when it was used for endpoints that did not expect such a request. > > > Diffs > ----- > > src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c > src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 > > > Diff: https://reviews.apache.org/r/67547/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benno Evers > >