----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/#review204840 -----------------------------------------------------------
include/mesos/master/master.proto Lines 605-606 (original), 605-609 (patched) <https://reviews.apache.org/r/67575/#comment287580> Please also update comments in `include/mesos/v1/master/master.proto` include/mesos/master/master.proto Lines 606 (patched) <https://reviews.apache.org/r/67575/#comment287581> ``` // This is the latest state of the task according to the agent, // which can be more recent... ``` - Zhitao Li On June 15, 2018, 5:45 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67575/ > ----------------------------------------------------------- > > (Updated June 15, 2018, 5:45 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Vinod Kone, > and Zhitao Li. > > > Bugs: MESOS-9000 > https://issues.apache.org/jira/browse/MESOS-9000 > > > Repository: mesos > > > Description > ------- > > Prior to this change, the master would only send TaskUpdated messages > to subscribers when the latest known task state on the agent changed. > > This implied that schedulers could not reliably wait for the status > information corresponding to specific state updates (i.e. TASK_RUNNING), > since there is no guarantee that subscribers get notified during > the time when this status update will be included in the status field. > > After this change, TaskUpdate messages are sent whenever the latest > acknowledged state of the task changes. > > > Diffs > ----- > > include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 > src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 > > > Diff: https://reviews.apache.org/r/67575/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benno Evers > >