----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67516/#review205010 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/resources.hpp Lines 328 (patched) <https://reviews.apache.org/r/67516/#comment287859> s/only consists of resource/consists of a resource/ src/tests/resources_tests.cpp Lines 1964 (patched) <https://reviews.apache.org/r/67516/#comment287860> Maybe s/diskInfo/disk/ since this isn't a `DiskInfo` object? - Greg Mann On June 11, 2018, 5:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67516/ > ----------------------------------------------------------- > > (Updated June 11, 2018, 5:34 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Repository: mesos > > > Description > ------- > > `isScalarQuantity()` checks if a `Resources` object > is "pure" scalar quantity i.e. its `Resource`(s) only has > name, type (set to scalar) and scalar fields set. > > Also added tests. > > > Diffs > ----- > > include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce > include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932 > src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca > src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 > src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 > > > Diff: https://reviews.apache.org/r/67516/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
