----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/#review205011 -----------------------------------------------------------
src/master/flags.cpp Lines 479 (patched) <https://reviews.apache.org/r/67513/#comment287862> Could you update the configuration documentation for the master as well? src/master/flags.cpp Lines 481-487 (patched) <https://reviews.apache.org/r/67513/#comment287861> How about: ``` One or more sets of resources that define the minimum allocatable resources for the allocator. The allocator will only offer resources that contain at least one of the specified sets. The resources in each set should be delimited by semicolons, and the sets should be delimited by the pipe character. (Example: `disk:1|cpu:1;mem:32` configures the allocator to only offer resources if they contain a disk resource of at least 1 megabyte, or if they contain both 1 cpu and 32 megabytes of memory.) ``` src/tests/hierarchical_allocator_tests.cpp Lines 179-183 (original), 179-192 (patched) <https://reviews.apache.org/r/67513/#comment287871> Do we have any tests which verify that the allocator's min. allocatable resources check is actually enforced? - Greg Mann On June 15, 2018, 10:02 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67513/ > ----------------------------------------------------------- > > (Updated June 15, 2018, 10:02 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-8935 > https://issues.apache.org/jira/browse/MESOS-8935 > > > Repository: mesos > > > Description > ------- > > This patch adds a new master flag `min_allocatable_resources`. > It specifies one or more resources quantities that define the > minimum allocatable resources for the allocator. The allocator > will only offer resources that are more than at least one of > the specified resources. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 647869286d46920b98521e219ce92c3260058c35 > src/master/allocator/mesos/allocator.hpp > c453c015b234deff7efd00269da25dcec8cbf1ae > src/master/allocator/mesos/hierarchical.hpp > e9d1742bb35004735e3cb357286b4e5b17436a5c > src/master/allocator/mesos/hierarchical.cpp > b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c > src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc > src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d > src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 > src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559 > src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c > src/tests/hierarchical_allocator_tests.cpp > c97b2ba0884a7ded867c2d80e4749de54c89b5e4 > src/tests/master_allocator_tests.cpp > e1aef8a9625a805e7ad2dfad37bfeedee82f160d > src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9 > src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351 > src/tests/resource_offers_tests.cpp > 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b > src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210 > > > Diff: https://reviews.apache.org/r/67513/diff/2/ > > > Testing > ------- > > make check > Fixed all existing tests. > Dedicate test added in a subsequent patch. > > > Thanks, > > Meng Zhu > >
