----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review205123 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_allocator_tests.cpp Lines 1281-1283 (patched) <https://reviews.apache.org/r/67517/#comment288092> Nit: could you make the ordering of these two lines the same here as it is down below for the allocatable agents? src/tests/master_allocator_tests.cpp Lines 1333 (patched) <https://reviews.apache.org/r/67517/#comment288093> Nit: `offers->size()` - Greg Mann On June 20, 2018, 8:40 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67517/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 8:40 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-8935 > https://issues.apache.org/jira/browse/MESOS-8935 > > > Repository: mesos > > > Description > ------- > > This test verifies that the allocator honors the > `min_allocatable_resources` flag and only offers resources > that are more than at least one of the specified resources quantity. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > e1aef8a9625a805e7ad2dfad37bfeedee82f160d > > > Diff: https://reviews.apache.org/r/67517/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
