----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67526/#review205273 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 604-611 (patched) <https://reviews.apache.org/r/67526/#comment288207> Why do we need to read /proc/mount? Couldn't we just iterate `subsystems` and `hierarchies` maps? src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 611 (patched) <https://reviews.apache.org/r/67526/#comment288208> multihashmap supports `contains`, right? src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 628 (patched) <https://reviews.apache.org/r/67526/#comment288209> s/symbol/symbolic/g? - Gilbert Song On June 19, 2018, 7:48 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67526/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 7:48 p.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Bugs: MESOS-8327 > https://issues.apache.org/jira/browse/MESOS-8327 > > > Repository: mesos > > > Description > ------- > > Added container-specific cgroup FS mounts. > > > Diffs > ----- > > src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 > src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 81c934318dcc2bcc9df594af0ee25f0334541a65 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 6d146729123b85e46f580a594fb9f9ac37b542f7 > > > Diff: https://reviews.apache.org/r/67526/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
