----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67390/#review205338 -----------------------------------------------------------
3rdparty/libprocess/src/windows/event_loop.hpp Lines 16 (patched) <https://reviews.apache.org/r/67390/#comment288254> What is this? Googling it doesn't yield any results, is it one of the headers owned by the mesos project? If so, why call it "windows/libwinio.hpp" instead of "windows/io.hpp"? The former makes it sounds like an external library? - Benjamin Mahler On June 21, 2018, 11:56 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67390/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 11:56 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668, MESOS-8671 and MESOS-8672 > https://issues.apache.org/jira/browse/MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8671 > https://issues.apache.org/jira/browse/MESOS-8672 > > > Repository: mesos > > > Description > ------- > > The libprocess eventloops are used to implement the `EventLoop`, > SocketImpl` and `io::read/write` interfaces. Thus, by providing those > implementations using libwinio, libprocess now supports the libwinio > backend. > > > Diffs > ----- > > 3rdparty/libprocess/src/windows/event_loop.hpp PRE-CREATION > 3rdparty/libprocess/src/windows/event_loop.cpp PRE-CREATION > 3rdparty/libprocess/src/windows/io.cpp PRE-CREATION > 3rdparty/libprocess/src/windows/poll_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67390/diff/3/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
