----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/ -----------------------------------------------------------
(Updated June 26, 2018, 11:48 a.m.) Review request for mesos. Changes ------- Switched around comment and #undef. Repository: mesos Description ------- The macro PICOJSON_USE_INT64 must always be defined when attempting to use stout's JSON facilities, since they unconditionally depend on these features. Previously, we relied on the Mesos build system to set that macro from the command line, but since we don't generate a separate pkg-config file for stout there is no way to convey this information to other users of stout. Even for users trying to use stout as part of a libmesos installation, it might be surprising that it is required to read CPPFLAGS if only the header-only stout part is to be used. Diffs (updated) ----- 3rdparty/stout/Makefile.am 5b922af6cd58dc03c44aacf88637e89f6e289702 3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14 Diff: https://reviews.apache.org/r/67632/diff/3/ Changes: https://reviews.apache.org/r/67632/diff/2-3/ Testing ------- Installed stout on my system and compiled an external program using stout's JSON processing functions. Thanks, Benno Evers
