----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67923/#review206142 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On July 15, 2018, 7:03 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67923/ > ----------------------------------------------------------- > > (Updated July 15, 2018, 7:03 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-8418 > https://issues.apache.org/jira/browse/MESOS-8418 > > > Repository: mesos > > > Description > ------- > > It turns out that cgroups::verify is expensive and leads to a severe > performance issue on the agent during container metrics collection > if there are a lot of containers on the agent. See MESOS-8418. > > Since cgroups::verify serves to provide a helpful error message, > this patch preserves the error message, but only if the read fails. > > Longer term, there probably needs to be some re-structuring of the > code to make verification caller-controlled, or perhaps the verify > code can occur consistently post-operation (as done in this patch), > or perhaps verify can be optimized substantially. > > > Diffs > ----- > > src/linux/cgroups.cpp b12e63c112a7aa7a6f7150359ff5409f8214067e > > > Diff: https://reviews.apache.org/r/67923/diff/1/ > > > Testing > ------- > > Ran through internal CI. > > > Thanks, > > Benjamin Mahler > >
