----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/#review206258 -----------------------------------------------------------
Patch looks great! Reviews applied: [67951, 67952, 67976, 67977, 67978, 67979, 67980] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 19, 2018, 8:47 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67980/ > ----------------------------------------------------------- > > (Updated July 19, 2018, 8:47 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > Liangyu Zhao, and Radhika Jandhyala. > > > Bugs: MESOS-5817 and MESOS-7527 > https://issues.apache.org/jira/browse/MESOS-5817 > https://issues.apache.org/jira/browse/MESOS-7527 > > > Repository: mesos > > > Description > ------- > > Several of these worked as-is, and the two firewall tests were fixed > by replace `path::join` (which joined with ``) with > `strings::join("/")`. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > 8baf60d8bbb675e26fea5e76c825ef73fedbc629 > > > Diff: https://reviews.apache.org/r/67980/diff/1/ > > > Testing > ------- > > `ctest -V` on Windows and Ubuntu 18.04 > > > Thanks, > > Andrew Schwartzmeyer > >