----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67985/#review206394 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/3rdparty/Makefile.am Lines 40-45 (original), 41-47 (patched) <https://reviews.apache.org/r/67985/#comment289328> Can we fix the order please? 3rdparty/stout/3rdparty/Makefile.am Lines 60-62 (original), 62-65 (patched) <https://reviews.apache.org/r/67985/#comment289329> Can we fix the order here as well? 3rdparty/stout/CMakeLists.txt Line 32 (original), 33 (patched) <https://reviews.apache.org/r/67985/#comment289331> While you're here, can you please fix the order as well? 3rdparty/stout/Makefile.am Lines 57-58 (original), 57-59 (patched) <https://reviews.apache.org/r/67985/#comment289330> Not your fault, but maybe you can fix it before adding more - Alexander Rukletsov On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67985/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benno Evers. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > This follows the approach used for picojson. > > > Diffs > ----- > > 3rdparty/stout/3rdparty/Makefile.am > cc831a93a57d970bc28d754acd04569780154bee > 3rdparty/stout/CMakeLists.txt 9cbb6f2a13fe9201fdebb9e9994d7725e53af083 > 3rdparty/stout/Makefile.am 44710c21d3c5a2bc2309b0fe10419712523d3187 > 3rdparty/stout/configure.ac 7e85c7efccdcbca8f3ef1173075384b0060a15c7 > > > Diff: https://reviews.apache.org/r/67985/diff/2/ > > > Testing > ------- > > Tested at the end of this chain, since this is split across > stout/libprocess/mesos. > > > Thanks, > > Benjamin Mahler > >
