-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review206471
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_benchmarks.cpp
Lines 508 (patched)
<https://reviews.apache.org/r/67823/#comment289444>

    I'd name this `numberOfActiveFrameworks` or `activeFrameworkCount`.



src/tests/master_benchmarks.cpp
Lines 553 (patched)
<https://reviews.apache.org/r/67823/#comment289445>

    s/Wait all/Wait for/?


- Gastón Kleiman


On July 17, 2018, 6:47 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
>     https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to